RFR: 8332125: [nmt] Totals in diff report should print out total malloc and mmap diffs [v2]

Thomas Stuefe stuefe at openjdk.org
Mon Jun 24 15:31:13 UTC 2024


On Wed, 5 Jun 2024 14:07:12 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This PR addresses [8332125](https://bugs.openjdk.org/browse/JDK-8332125) enabling printing total malloc and mmap diffs when printing an NMT diff report. 
>> 
>> Testing: 
>> - [x] Added test case passes. 
>> 
>> Thanks, 
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8332125
>  - 8332125: [nmt] Totals in diff report should print out total malloc and mmap diffs

src/hotspot/share/nmt/memReporter.cpp line 478:

> 476:   print_malloc_diff(current_malloced_bytes, current_count, early_malloced_bytes,
> 477:                     early_count, mtNone);
> 478:   out->print_cr("\n");

Please replace with two `out->cr()`, same below (I try to slowly get rid of literal newlines)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19373#discussion_r1627873426


More information about the hotspot-runtime-dev mailing list