RFR: 8314653: Metaspace: remove allocation guard feature [v2]
Thomas Stuefe
stuefe at openjdk.org
Tue Jun 25 06:30:50 UTC 2024
> In Metaspace in debug builds, one can guard allocations. This has been a useful feature in during implementation of JEP 387 to find bugs, but has not found much use thereafter, and remains an obscure and underused feature.
>
> But these guards cause quite a bit of complexity, mainly since they make testing difficult: with guards on, predicting arena growth gets quite complex.
>
> I propose to remove this feature to reduce Metaspace complexity.
>
> Tests: local (mac m1, Linux x64) Metaspace tests. GHAs.
Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'openjdk:master' into metaspace-remove-allocation-guard
- start
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/19611/files
- new: https://git.openjdk.org/jdk/pull/19611/files/a2dbc1e3..e4dbaee1
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=19611&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=19611&range=00-01
Stats: 41983 lines in 1010 files changed: 25379 ins; 12767 del; 3837 mod
Patch: https://git.openjdk.org/jdk/pull/19611.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/19611/head:pull/19611
PR: https://git.openjdk.org/jdk/pull/19611
More information about the hotspot-runtime-dev
mailing list