RFR: 8335007: Inline OopMapCache table
Thomas Stuefe
stuefe at openjdk.org
Wed Jun 26 08:31:12 UTC 2024
On Wed, 26 Jun 2024 08:11:31 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> I'm not a maintainer of this code, but this change looks good to me.
>
> I reacted a little bit when I saw the `_size` usage in the array expression, thinking that you were using a member variable. It turns out that it is just a constant with a very unconventionally named (for HotSpot) constant. Would anyone object if we/I changed the name of these constants in a follow-up RFE?
I am fine with renaming it to something that does not look like a member. "size" ? "tablesize"? Also, make it a static constexpr? Do we still use enums for constants?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19882#issuecomment-2191117863
More information about the hotspot-runtime-dev
mailing list