RFR: 8332124: Jcmd processing should accept the "help" sub option as command argument [v3]

Thomas Stuefe stuefe at openjdk.org
Fri Jun 28 05:54:20 UTC 2024


On Thu, 27 Jun 2024 18:38:14 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This PR addresses [8332124](https://bugs.openjdk.org/browse/JDK-8332124) enabling jcmd to accept "help" as an argument to subcommands. 
>> 
>> Testing: 
>> - [x] Verified running `jcmd 4711 VM.metaspace help` works along with other subcommands. 
>> - [x] Added test case passes. 
>> 
>> Thanks, 
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Updating copyright header
>  - Modifying usage to --help and -help. Updated ensuing test case to test both
>  - Updating copyright headers

I would not use help with one dash. Reason: if we ever wanted to switch to posix conform arguments, this would translate to four flags, h+e+l+p. 

I would either use -h or --help, preferably the former.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19776#issuecomment-2196190900


More information about the hotspot-runtime-dev mailing list