RFR: JDK-8334217 : [AIX] Misleading error messages after JDK-8320005 [v2]

Suchismith Roy sroy at openjdk.org
Fri Jun 28 14:50:18 UTC 2024


On Fri, 28 Jun 2024 11:38:41 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> > > Are these strings not locale dependent? How would this work with a different locale?
> > 
> > 
> > In principle this might be the case, but our special code does the existence check beforehand (you know the 'loading a dll twice without getting a new handle') and this check returns the string as is. See `Aix_dlopen()` in porting_aix.cpp.
> 
> Okay. But grepping for an english error string verbatim seems really iffy. @suchismith1993 Please factor out the string at least, e.g. as a common define.

You using a #define ? or declaring a string --> const error_report[] = "No Such File or Directory";

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19887#issuecomment-2197108415


More information about the hotspot-runtime-dev mailing list