RFR: 8335217: Fix memory ordering in ClassLoaderData::ChunkedHandleList [v4]
Stefan Karlsson
stefank at openjdk.org
Fri Jun 28 15:10:21 UTC 2024
On Fri, 28 Jun 2024 10:00:50 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> stefank's comments
>
> src/hotspot/share/classfile/classLoaderData.cpp line 184:
>
>> 182:
>> 183: ClassLoaderData::ChunkedHandleList::~ChunkedHandleList() {
>> 184: Chunk* c = _head;
>
> This really should not be needed and just becomes something that people will wonder about why it is there. If we ever have concurrent accesses here we have a use-after-free situation and have much bigger issues to deal with. I'd like to see this reverted.
@zhengyu123 I still would like to see this line getting reverted.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19919#discussion_r1658893514
More information about the hotspot-runtime-dev
mailing list