RFR: 8335217: Fix memory ordering in ClassLoaderData::ChunkedHandleList [v3]

Stefan Karlsson stefank at openjdk.org
Fri Jun 28 15:10:23 UTC 2024


On Fri, 28 Jun 2024 10:02:52 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert some of previous changes
>
> src/hotspot/share/classfile/classLoaderData.cpp line 261:
> 
>> 259: #ifndef PRODUCT
>> 260: bool ClassLoaderData::ChunkedHandleList::owner_of(oop* oop_handle) {
>> 261:   Chunk* chunk = Atomic::load_acquire(&_head);
> 
> It's unclear to me if this is actually concurrently accessed, but if we want to be conservative and add it here, then that's fine. However, then I'd also like to see an Atomic::load of chunk->_size.

Thanks for fixing this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19919#discussion_r1658891574


More information about the hotspot-runtime-dev mailing list