RFR: JDK-8334217 : [AIX] Misleading error messages after JDK-8320005 [v2]

Thomas Stuefe stuefe at openjdk.org
Sat Jun 29 13:30:19 UTC 2024


On Sat, 29 Jun 2024 10:42:27 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> > But by using a central common definition for the string you at least minimize the chance of this breaking if someone changes the error messages, and signal too the code reader that the message may be used somewhere else.
> 
> Great point. Thanks, thats good learning. We had worked on checking error numbers before, but there were limitations to that. Is the current #define code i pushed ,ok ?

No, since you still only use it in one place, and in porting_aix.cpp we still use a literal string.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19887#issuecomment-2198192780


More information about the hotspot-runtime-dev mailing list