RFR: 8319932: [JVMCI] class unloading related tests can fail on libgraal
David Holmes
dholmes at openjdk.org
Fri Mar 1 05:52:42 UTC 2024
On Thu, 29 Feb 2024 13:24:16 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> I think we would only need that second version because the first/existing one is unreliable! But given all these "incidental" things that can keep classes strongly reachable reliability may be a pipe-dream here. But even if it is just a better version I would still prefer to see this in the utility code than individual tests.
>>
>> BTW if this is a C1 issue any idea why we do not see it with C1 + C2 ?
>
> Because `TypeProfileWidth` is only 2 when Graal is not being used so there's very little chance of `InitExceptionUnloadTest$SpecialException` being in a type profile (see PR description).
>
> Just to be clear, you're saying I should add `ClassUnloadCommon.triggerUnloading(String... namesOfClassesToBeUnloaded)` in this PR?
Yes please add that and have the test use it. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18044#discussion_r1508509367
More information about the hotspot-runtime-dev
mailing list