RFR: 8322170: Update deprecated/obsolete/expired flags table for GC
David Holmes
dholmes at openjdk.org
Fri Mar 1 06:03:52 UTC 2024
On Thu, 29 Feb 2024 16:05:19 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Set expire release to jdk24 like the neighboring entries.
One nit, but otherwise seems fine. Thanks.
src/hotspot/share/runtime/arguments.cpp line 520:
> 518: { "G1ConcRSHotCardLimit", JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::jdk(24) },
> 519: { "RefDiscoveryPolicy", JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::jdk(24) },
> 520: { "MetaspaceReclaimPolicy", JDK_Version::undefined(), JDK_Version::jdk(21), JDK_Version::undefined() },
Nit: please move MetaspaceReclaimPolicy to before the flags now expiring in 24 so that "undefined" remains first.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18069#pullrequestreview-1910368567
PR Review Comment: https://git.openjdk.org/jdk/pull/18069#discussion_r1508515038
More information about the hotspot-runtime-dev
mailing list