RFR: 8327098: GTest needs larger combination limit
Aleksey Shipilev
shade at openjdk.org
Fri Mar 1 17:20:53 UTC 2024
On Fri, 1 Mar 2024 15:14:15 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> The current value of LogSelectionList::MaxSelections is too small, causing GTest failures. This increases the value from 256 to 320.
>
> It looks okay, but I have questions:
> 1. Does it happen in mainline right now?
> 2. Why are we hitting it with [JDK-8324649](https://bugs.openjdk.org/browse/JDK-8324649) PR? I don't see new logging tags added there.
> @shipilev: @earthling-amzn shares that he has seen this same failure on our Shenandoah repository and have applied a similar fix there. It may be that the new ShenandoahFreeSet introduces more combinations of log tags than had been present previously.
Weird, I just tried to run all gtests with #17561, and it passes well without these adjustments. Puzzling.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18083#issuecomment-1973578702
More information about the hotspot-runtime-dev
mailing list