RFR: 8326611: Clean up vmTestbase/nsk/stress/stack tests [v5]

David Holmes dholmes at openjdk.org
Mon Mar 4 05:15:45 UTC 2024


On Thu, 29 Feb 2024 18:13:04 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The vmTestbase/nsk/stress/stack might be slightly refactored to improve reading. Mostly, simple refactoring.
>> Test logic was not changed, except removing verbose mode and enabling printing.
>
> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8326611
>  - removed tests from tier1.
>  - Merge branch '8326611' of https://github.com/lmesnik/jdk into 8326611
>  - Update test/hotspot/jtreg/vmTestbase/nsk/stress/stack/stack009.java
>    
>    Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>  - moved tests into runtime.
>  - removed spaces.
>  - 8326611: Clean up vmTestbase/nsk/stress/stack tests

Copyrights need updating in many of the files.

What is the `Terminator` that some of the tests were using but now are not?

Do we really have 19 different stackoverflow tests here? The differences in some of the tests seem inconsequential in terms of what they are testing e.g. 004 uses a static method and 005 uses a non-static method (based on the descriptions).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17993#pullrequestreview-1913385380


More information about the hotspot-runtime-dev mailing list