RFR: 8319932: [JVMCI] class unloading related tests can fail on libgraal [v2]

Doug Simon dnsimon at openjdk.org
Mon Mar 4 08:27:53 UTC 2024


On Mon, 4 Mar 2024 04:34:07 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move retry loop for class unloading to lib code
>
> test/lib/jdk/test/lib/classloader/ClassUnloadCommon.java line 101:
> 
>> 99:                     }
>> 100:                 }
>> 101:             }
> 
> Could we use a `Iterator` to iterate the set and remove the element? It seems we only need to iterate the alive classes instead of all the classes everytime.

It's not worth the extra complexity of handling concurrent modification. The `classNames` list is only expected to have vey few elements.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18044#discussion_r1510753362


More information about the hotspot-runtime-dev mailing list