RFR: 8326936: RISC-V: Shenandoah GC crashes due to incorrect atomic memory operations [v5]
MaxXing
duke at openjdk.org
Tue Mar 5 07:24:03 UTC 2024
On Tue, 5 Mar 2024 06:59:53 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> MaxXing has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix value types, macro conditions and comments.
>
> src/hotspot/os_cpu/linux_riscv/atomic_linux_riscv.hpp line 157:
>
>> 155: FULL_MEM_BARRIER;
>> 156: }
>> 157: return old_value;
>
> Should we do an explicit type conversion here? Like: `return (T)old_value;`
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18039#discussion_r1512238817
More information about the hotspot-runtime-dev
mailing list