RFR: JDK-8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX

Guoxiong Li gli at openjdk.org
Tue Mar 5 10:25:56 UTC 2024


On Mon, 4 Mar 2024 10:13:13 GMT, Joachim Kern <jkern at openjdk.org> wrote:

> Even after recent fixes like
> https://bugs.openjdk.org/browse/JDK-8305765
> the test runtime/CompressedOops/CompressedClassPointers.java fails on AIX.
> 
> This error results from the fact, that on AIX the shmat() allocation granularity is 256MB instead of the standard Pagesize (4KB or 64KB).
> 
> Because my first proposal (PR 17708) of introducing a new method os::vm_shm_allocation_granularity() in the shared hotspot code was rejected I now encapsulate the difference in ifdef AIX brackets.

I don't have a AIX device to run the related test. But the patch looks good.

A trivially possible problem is that it seems not so good to repeat the same comments in all the code places. But I don't have a better alternative way to solve such issue. So I am OK with it now.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18105#pullrequestreview-1916490890


More information about the hotspot-runtime-dev mailing list