RFR: 8326611: Clean up vmTestbase/nsk/stress/stack tests [v6]

[Coleen Phillimore]

On Mon, 4 Mar 2024 19:56:13 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The vmTestbase/nsk/stress/stack might be slightly refactored to improve reading. Mostly, simple refactoring.
>> Test logic was not changed, except removing verbose mode and enabling printing.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Terminator is removed.

This continues to look really good.  There were several stack tests that were similar but would trigger StackOverflow in subtly different places, so there were (at the time) no duplicates.  Each had a bug fixed for it at the time. I remember getting segv in the 'instanceof' native code and some println calls which determinted how large to create the StackShadowPages.  There still seem to be some instanceof in the catches so that's good.  If there are true duplicates now, it would be good to remove them.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17993#pullrequestreview-1917632107