RFR: JDK-8322943: runtime/CompressedOops/CompressedClassPointers.java fails on AIX [v3]

[Thomas Stuefe]

On Wed, 6 Mar 2024 13:25:43 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:

> For the n-times copied logic: There are only two places in the JVM coding. The others are in tests. Obviously, the tests must be adapted to the JVM coding.
Joachim's original proposal was to encapsulate this in a new function. This moves the logic into the aix coding. You voted against this. So what to do now?

Okay. Can we do this at least without copy-pasting the same code 6 times over in test_os_reserve_between.cpp? I mean, guys, really? A file-scope define at the start of the file,  or a file-scope static function? That alone would reduce the patch size to about a third.

My problem with `#ifdef AIX` is that we _never ever get rid of that stuff_. Because nobody knows AIX. So other developers are afraid to touch that code. And because we few AIX devs never clean stuff up in the AIX code base - since no company spends the resources - we are stuck.

The 4K page mode is such an example. We added 64K page mode way back when, and the 4K mode was a fallback for AIX 5.2. AIX 5.2 is EOL since 2009. So I think we could have long hard-wired 64K page mode. But nobody did, because nobody has the time for it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18105#issuecomment-1983244796