RFR: 8327410: Add hostname option for UL file names [v2]

Fredrik Bredberg fbredberg at openjdk.org
Fri Mar 8 12:31:52 UTC 2024


On Thu, 7 Mar 2024 18:32:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Get the hostname only if the user explicitly requests it
>
> Hi Fredrik,
> 
> I'm sorry but I think this needs some changes :-). This PR saves the hostname regardless if the hostname is requrested as part of the log filename or not. This means that the hostname is present in the heap of the JVM process, but I believe that the hostname should be considered confidential data. We should really only get the hostname if the user explicitly requests this.
> 
> @dholmes-ora , could you confirm whether what I'm saying is correct or not?
> 
> Also, we will be needing a man page update on this, which is separate to the usual PR process.
> 
> Thanks for doing this work!
> Johan

@jdksjolen , @dholmes-ora
Thanks for comments. We now only get the host name if the user explicitly requests it.
I also added the missing documentation to `java -Xlog:help`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18153#issuecomment-1985609208


More information about the hotspot-runtime-dev mailing list