RFR: 8327651: Rename DictionaryEntry members related to protection domain [v2]

Ioi Lam iklam at openjdk.org
Tue Mar 12 22:26:40 UTC 2024


On Tue, 12 Mar 2024 18:53:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @coleenp review -- add comments about avoiding Java upcalls
>
> src/hotspot/share/classfile/dictionary.hpp line 114:
> 
>> 112:   // The usage of the PD set can be seen in SystemDictionary::validate_protection_domain()
>> 113:   // It is essentially a cache to avoid repeated Java up-calls to
>> 114:   // ClassLoader.checkPackageAccess().
> 
> This was a pretty helpful comment, especially that we're trying to avoid repeated Java upcalls.  Why not just rename validate_protection_domain here too.

I updated the comment to talk about avoiding the Java upcalls and to reflect the new names.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18222#discussion_r1522187614


More information about the hotspot-runtime-dev mailing list