RFR: 8327651: Rename DictionaryEntry members related to protection domain [v2]

[David Holmes]

On Tue, 12 Mar 2024 22:26:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Rename `DictionaryEntry::_pd_set` to `_package_access_cache`, and rename all related methods accordingly.
>> 
>> The old name was very confusing. It makes one wonder,
>> 
>>> Is `DictionaryEntry::_pd_set` related to the `java.lang.Class.getProtectionDomain()` of the `DictionaryEntry::_instance_klass` in any way?
>> 
>> (Hint, they have absolutely no relationship to each other).
>> 
>> I am making this PR as future changes in the Leyden project may be touching this area. I don't want the reviewers of my future PRs be confused by this code.
>> 
>> ----------------
>> This PR is mostly name changes and comment clarification.
>> 
>> Other than a log message change for clarification, there are no behavioral changes in this PR.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @coleenp review -- add comments about avoiding Java upcalls

Seems a little verbose, but as it won't be relevant for that much longer I'm not overly concerned.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18222#pullrequestreview-1933367512