RFR: JDK-8327971: Multiple ASAN errors reported for metaspace [v3]

[Thomas Stuefe]

On Wed, 13 Mar 2024 09:15:39 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove stray newline
>>  - fixes
>
> src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp line 438:
> 
>> 436:   // Down here, from ASAN's view, this memory may be poisoned, since we only unpoison
>> 437:   // way up at the ChunkManager level.
>> 438: #if !INCLUDE_ASAN
> 
>> But from the newest code, which uses only INCLUDE_ASAN instead of ASAN_ONLY and NOT_ASAN, I think you can use the exiting ADDRESS_SANITIZER instead of adding INCLUDE_ASAN
> 
> For example, you can use `#ifndef ADDRESS_SANITIZER` directly here and don't need a new macro `INCLUDE_ASAN`.

INCLUDE_xxx, as a numerical, is our normal notation for these things.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18230#discussion_r1522918970