RFR: 8328111: Convert Runtime tests to use the ClassFile API instead of ASM [v9]
Oussama Louati
duke at openjdk.org
Fri Mar 15 10:12:51 UTC 2024
On Thu, 14 Mar 2024 17:44:16 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> Oussama Louati has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - removing unnecessary whitespaces
>> - convert BadMethodHandles to use classFile API
>
> test/hotspot/jtreg/runtime/ConstantPool/BadMethodHandles.java line 62:
>
>> 60: ClassDesc.of("BadInterfaceMethodref"), "staticM", "()V");
>> 61:
>> 62: bytes = ClassFile.of().build(ClassDesc.of("BadInterfaceMethodref"),
>
> can't it be merged with line 54?
Done
> test/hotspot/jtreg/runtime/ConstantPool/BadMethodHandles.java line 103:
>
>> 101: byte[] bytes;
>> 102:
>> 103: bytes = ClassFile.of().build(ClassDesc.of("IBad"),
>
> Also, just merger with line 181 or return this result.
Done
> test/hotspot/jtreg/runtime/finalStatic/FinalStatic.java line 72:
>
>> 70:
>> 71: private byte[] loadClassData(String name) throws Exception {
>> 72: byte[] bytes = null;
>
> = null is not needed.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18271#discussion_r1526046778
PR Review Comment: https://git.openjdk.org/jdk/pull/18271#discussion_r1526046550
PR Review Comment: https://git.openjdk.org/jdk/pull/18271#discussion_r1526046309
More information about the hotspot-runtime-dev
mailing list