RFR: 8328111: Convert Runtime tests to use the ClassFile API instead of ASM [v10]
ExE Boss
duke at openjdk.org
Sat Mar 16 22:18:33 UTC 2024
On Sat, 16 Mar 2024 09:40:19 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Oussama Louati has updated the pull request incrementally with one additional commit since the last revision:
>>
>> remove redundant byte[] declaration and directly return the result instead
>
> test/hotspot/jtreg/runtime/verifier/TestMultiANewArray.java line 74:
>
>> 72: .invokespecial(CD_Object, INIT_NAME, MTD_void)
>> 73: .return_())
>> 74: .withMethodBody("main", MethodTypeDesc.of(CD_void, CD_String.arrayType()),ACC_PUBLIC + ACC_STATIC,
>
> Suggestion:
>
> .withMethodBody("main", MethodTypeDesc.of(CD_void, CD_String.arrayType()), ACC_PUBLIC + ACC_STATIC,
Suggestion:
.withMethodBody("main", MethodTypeDesc.of(CD_void, CD_String.arrayType()), ACC_PUBLIC | ACC_STATIC,
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18271#discussion_r1527153054
More information about the hotspot-runtime-dev
mailing list