RFR: 8328275: CodeCache::print_internals should not be called in PRODUCT code

David Holmes dholmes at openjdk.org
Mon Mar 18 04:42:26 UTC 2024


On Fri, 15 Mar 2024 16:01:01 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

> Please review this trivial patch that fixes the compilation on Windows with `--enable-jvm-feature-link-time-opt`.

As `PrintCodeCache2` is a develop flag that defaults to `false`, the expectation is that the compiler will elide the code block that has now been conditionalized. But the fix is fine if needed to address this corner case.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18330#pullrequestreview-1941965824


More information about the hotspot-runtime-dev mailing list