RFR: 8325871: Move StringTable and SymbolTable rehashing calls [v2]

Axel Boldt-Christmas aboldtch at openjdk.org
Mon Mar 18 13:12:28 UTC 2024


On Fri, 15 Mar 2024 14:49:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Move the rehashing calls as a test in the concurrent work - ie. trigger concurrent work and check for the need to do rehashing. 
>> 
>> Tested with tier1-7.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   In CHT copy_nodes_to is really rehash_nodes_to, so rename it less generically.  This function can never fail now that rehashing is done in a dedicatd safepoint for that purpose, so resizing will never be concurrent.  do_hash moved into rehash_table.

lgtm. 

Makes room for a lot more cleanups surrounding `ParallelCleanupTask` and `GuaranteedSafepointInterval`. Thanks.

-------------

Marked as reviewed by aboldtch (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18240#pullrequestreview-1942919373


More information about the hotspot-runtime-dev mailing list