RFR: 6942632: Hotspot should be able to use more than 64 logical processors on Windows [v2]
David Holmes
dholmes at openjdk.org
Tue Mar 19 01:54:21 UTC 2024
On Wed, 28 Feb 2024 06:31:58 GMT, Saint Wesonga <duke at openjdk.org> wrote:
>> Hi,
>>
>> Please avoid implicit casts from int to bool. I noted two examples, but there are more in the code. I have a preference for avoiding unnecessary indentation, and I noted one place where this can be done, but consider that a nit and not required :-).
>>
>> Other than that, the code seems correct and the idea itself sound.
>
>> Hi,
>>
>> Please avoid implicit casts from int to bool. I noted two examples, but there are more in the code. I have a preference for avoiding unnecessary indentation, and I noted one place where this can be done, but consider that a nit and not required :-).
>>
>> Other than that, the code seems correct and the idea itself sound.
>
> I have removed the implicit casts in the new code I introduced. Please let me know if I missed any - I did not remove implicit casts from any of the previously existing code.
@swesonga you have not progressed the CSR request for this issue.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17576#issuecomment-2005596602
More information about the hotspot-runtime-dev
mailing list