RFR: 8319251: [REDO] Change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT

Daniel D. Daugherty dcubed at openjdk.org
Tue Mar 19 13:29:21 UTC 2024


On Tue, 19 Mar 2024 03:02:46 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> A fix to change LockingMode default from LM_LEGACY to LM_LIGHTWEIGHT.
>
> test/jtreg-ext/requires/VMProps.java line 422:
> 
>> 420: 
>> 421:     /**
>> 422:      * @return "true" if compiler in use supports RTM and false otherwise.
> 
> Why did you put true in quotes?? The false is not in quotes. If anything it should be `{@code true}` and `{@code false}` but as we are never going to generate javadoc for this the formatting is immaterial.

I got the formatting for the comment from which ever existing comment that I copied
to create the new ones. For whatever reason, these functions return String so "true"
and "false" are accurate. I'll fix my new ones to all be the same, but I'm not going to
try to clean up the existing ones.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17932#discussion_r1530365928


More information about the hotspot-runtime-dev mailing list