RFR: 8328630: Add logging when needed symbols in dll are missing.

[David Holmes]

On Wed, 20 Mar 2024 16:58:28 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> Hi, please consider this additional logging.
> 
> Thanks, Robbin

Changes requested by dholmes (Reviewer).

src/hotspot/os/posix/os_posix.cpp line 718:

> 716:     const char* tmp = ::dlerror();
> 717:     if (tmp != nullptr) {
> 718:       log_debug(os)("Symbol %s not found in dll: %s", name, tmp);

It is unclear whether failing to locate a symbol simply because it isn't there is considered an error? dlsym and dlerror docss are silent on that. So I'm not clear if the logging happens for all missing symbols, or only where the dlsym actually encountered an error? If this is only meant for actual errors then the message seems wrong. If the intent is to report all missing symbols, then making the log statement conditional seems wrong.

-------------

PR Review: https://git.openjdk.org/jdk/pull/18404#pullrequestreview-1950835323
PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1533296726