RFR: 8328630: Add logging when needed symbols in dll are missing. [v2]

David Holmes dholmes at openjdk.org
Thu Mar 21 10:41:21 UTC 2024


On Thu, 21 Mar 2024 10:28:47 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider this additional logging.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   clear errors, comment

src/hotspot/os/posix/os_posix.cpp line 714:

> 712: 
> 713: void* os::dll_lookup(void* handle, const char* name) {
> 714:   ::dlerror(); // Clear any previous error

Uggghhh! It is awful that we need to do that. Now this needs to be guarded with `log_is_enabled(Debug, os)`. Otherwise we need to check for the performance hit of doing this, particularly during startup.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1533624093


More information about the hotspot-runtime-dev mailing list