RFR: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods

[Julian Waters]

On Tue, 16 Jan 2024 01:56:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I think VMError::report_and_die calls os::exit and os::abort (both of which call exit_process_or_thread), and vaguely also remember it calling raise_fail_fast, but to answer that question definitively, probably need Kim's confirmation. Can do on that second part, but out of curiosity, is there a difference between std:: and :: for C methods?
>
>> is there a difference between std:: and :: for C methods?
> 
> There are differences between C++ exit and C exit, as the former performs additional C++ cleanup - that said I'm unclear if we actually end up executing the C or the C++ version of the function! But we don't use the `std::` namespace in this area. Also we have the `ALLOW_C_FUNCTION` macros to make it clear that it is correct to be calling something like `::exit` or `::abort` rather than `os::exit` or `os::abort`.

@dholmes-ora Sorry for the page, is Kim around?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17366#issuecomment-2014825112