RFR: 8247449: Revisit the argument processing logic for MetaspaceShared::disable_optimized_module_handling() [v2]

[Calvin Cheung]

On Tue, 26 Mar 2024 22:03:44 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iklam comments
>
> src/hotspot/share/runtime/arguments.cpp line 2499:
> 
>> 2497:           match_option(option, "-Djdk.module.validation", &value)) {
>> 2498:         CDSConfig::handle_incompatible_property((const char*)option->optionString + 2);
>> 2499:       }
> 
> Since add_property can be called in multiple places, I think this check should be put inside add_property().
> 
> Also, for better modularity, the set of properties should be listed inside CDSConfig.cpp. Maybe something like this:
> 
> 
> bool Arguments::add_property(...) {
>   ...
>   CDSConfig::check_incompatible_property(key, value); // checks the 3 properties inside
> }

Per our discussion offline, only call `CDSConfig::check_incompatible_property()` for `ExternalProperty`.


  if (internal == ExternalProperty) {
    CDSConfig::check_incompatible_property(key, value);
  }


I've pushed another commit based on your comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18495#discussion_r1540385783