RFR: 8329150: Remove CDS support for LatestMethodCache [v2]

[Coleen Phillimore]

On Wed, 27 Mar 2024 18:06:39 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The CDS support for LatestMethodCache has no meaningful performance benefit. I am removing it for simplcity.
>> 
>> I also cleaned up the code a bit
>> - No need to put LatestMethodCache in universe.hpp.
>> - No need to use TRAPS in the init function
>> - No need to malloc the LatestMethodCache objects
>
> Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Move definitions of _finalizer_register_cache close to the declaration of LatestMethodCache
>  - @coleenp comments - no need to expose LatestMethodCache in universe.hpp

One more suggestion.  The functions were spread across universe.cpp and they really should be together.

src/hotspot/share/memory/universe.cpp line 1261:

> 1259:   _method_idnum = m->method_idnum();
> 1260:   assert(_method_idnum >= 0, "sanity check");
> 1261: }

Can you move this function up to where the accessor are too?   Like around line 930?

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18516#pullrequestreview-1964472391
PR Review Comment: https://git.openjdk.org/jdk/pull/18516#discussion_r1541858535