RFR: 8329150: Remove CDS support for LatestMethodCache [v3]

Matias Saavedra Silva matsaave at openjdk.org
Wed Mar 27 20:58:31 UTC 2024


On Wed, 27 Mar 2024 20:11:44 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The CDS support for LatestMethodCache has no meaningful performance benefit. I am removing it for simplcity.
>> 
>> I also cleaned up the code a bit
>> - No need to put LatestMethodCache in universe.hpp.
>> - No need to use TRAPS in the init function
>> - No need to malloc the LatestMethodCache objects
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved methods relocated to LatestMethodCache close to each other

Fix looks good, thanks! I have one format comment but nothing major.

src/hotspot/share/memory/universe.cpp line 111:

> 109: };
> 110: 
> 111: static LatestMethodCache _finalizer_register_cache; // static method for registering finalizable objects

Could you align these comments?

-------------

Marked as reviewed by matsaave (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18516#pullrequestreview-1964746754
PR Review Comment: https://git.openjdk.org/jdk/pull/18516#discussion_r1542027975


More information about the hotspot-runtime-dev mailing list