RFR: 8329150: Remove CDS support for LatestMethodCache [v4]

Ioi Lam iklam at openjdk.org
Thu Mar 28 03:43:50 UTC 2024


On Wed, 27 Mar 2024 23:14:11 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   aligned and simplified comments
>
> src/hotspot/share/memory/universe.cpp line 949:
> 
>> 947: Method* LatestMethodCache::get_method() {
>> 948:   if (klass() == nullptr) return nullptr;
>> 949:   InstanceKlass* ik = InstanceKlass::cast(klass());
> 
> Sorry for the bits and pieces.  Hopefully the last thing.  Can _klass be a InstanceKlass so we don't need this cast?

Thanks for the suggestions. This code is very old and really needs to be cleaned up. I also removed the unnecessary accessor functions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18516#discussion_r1542271718


More information about the hotspot-runtime-dev mailing list