RFR: 8328630: Add logging when needed symbols in dll are missing. [v2]
Robbin Ehn
rehn at openjdk.org
Thu Mar 28 13:54:34 UTC 2024
On Thu, 28 Mar 2024 12:27:19 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Make sense?
>
> Not from a programming perspective! That would be like successful syscalls not resetting errno to zero. Then again maybe they don't? Hmmm.
>
> If this returns the last error that ever happened then all uses of the potential error producing functions should always be followed by a call to `dlerror` if an error occurred. I'm guessing we don't actually do that? So the one place we do check has to make a dummy call to clear the error first - blegghh! :(
Agreed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18404#discussion_r1543019968
More information about the hotspot-runtime-dev
mailing list