RFR: 8325883: Move Monitor Deflation reporting out of safepoint cleanup

Erik Österlund eosterlund at openjdk.org
Thu Mar 28 14:11:33 UTC 2024


On Wed, 27 Mar 2024 23:37:30 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Moved monitor logging out of the safepoint cleanup code to intervals in the MonitorDeflationThread, and made logging come out at the specified level (Info, Debug or Trace).
> 
> Tested with tier1-4.

Looks good, just need to fix a comment before pushing. Don't need to see the new version.

src/hotspot/share/runtime/synchronizer.cpp line 1962:

> 1960: // we are trying to exit the VM. When we are trying to exit the VM, the
> 1961: // list walker functions can run in parallel with the other list
> 1962: // operations so spin-locking is used for safety.

Maybe get rid of the spin locking comments. Otherwise this looks great!

-------------

Marked as reviewed by eosterlund (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18528#pullrequestreview-1966334460
PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543046503


More information about the hotspot-runtime-dev mailing list