RFR: 8323576: [Windows] Fallthrough to ::abort instead of os::infinite_sleep for noreturn methods [v2]

[Kim Barrett]

On Fri, 19 Jan 2024 12:09:37 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Okay. The `_Exit` is the ISO C function, but POSIX also defines `_exit` (not that that is relevant to Windows). I can't see anything saying that Microsoft have deprecated `_exit` though:
>> https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/exit-exit-exit?view=msvc-170
>> If we were to change this I would still want the `ALLOW_C_FUNCTION`. Thanks
>
> I guess I can leave that _Exit change for another day, it wouldn't make sense to have ALLOW_C_FUNCTION on something that is not banned by HotSpot after all

For the record, `::_exit` _is_ forbidden.
https://github.com/openjdk/jdk/blob/7ac2f914aadf7fb12b7258e54efae959e15d6721/src/hotspot/share/utilities/globalDefinitions.hpp#L191
It might be deprecated as part of the optional defining and deprecation of POSIX names:
https://learn.microsoft.com/en-us/cpp/c-runtime-library/compatibility?view=msvc-170

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17366#discussion_r1543367032