RFR: 8325883: Move Monitor Deflation reporting out of safepoint cleanup [v2]

Daniel D. Daugherty dcubed at openjdk.org
Thu Mar 28 18:21:35 UTC 2024


On Thu, 28 Mar 2024 16:04:31 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/synchronizer.cpp line 1962:
>> 
>>> 1960: // we are trying to exit the VM. When we are trying to exit the VM, the
>>> 1961: // list walker functions can run in parallel with the other list
>>> 1962: // operations so spin-locking is used for safety.
>> 
>> Maybe get rid of the spin locking comments. Otherwise this looks great!
>
> I updated this comment to remove the mention of spin-locking which I think it used to do.  Thanks!

Yes, used to have a much more complicated async deflation mechanism and we had to
use spin-locking for safety. @fisk simplified this a long time ago...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18528#discussion_r1543426052


More information about the hotspot-runtime-dev mailing list