RFR: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling [v2]

[Andrei Pangin]

On Fri, 29 Mar 2024 05:55:01 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Andrei Pangin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rephrased comment about AsyncGetCallTrace reentrancy
>
> src/hotspot/share/runtime/thread.hpp line 664:
> 
>> 662:   ThreadInAsgct(Thread* thread) : _thread(thread) {
>> 663:     assert(thread != nullptr, "invariant");
>> 664:     // AsyncGetCallTrace is reentrant - save the previous state.
> 
> Nit: It is possible to rephrase this comment as follows:
> 
>   // Allow AsyncGetCallTrace to be reentrant - save the previous state.
> ``

Thank you for the review - I updated the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18504#discussion_r1544400438