RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed [v3]

[Thomas Stuefe]

On Wed, 1 May 2024 17:46:57 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> > @iklam Sorry, had to force push because I messed up the PR branch somehow.
> 
> I think it's possible to just discard your local branch, and check out a new version from the PR, then make changes on top of it. That way you can avoid forced pushes.

Its possible, I do this a lot when I mess up locally. But in this case, I had already accidentally pushed a broken merge to my GH fork, and then saw it touches >5000 files and has >300 commits. No idea what went wrong, but the only way to fix this that I found was to locally redo the patch and switch the branch.

> 
> > The new version contains the change proposed by you - getting rid of explicit ihash generation when dumping - as well as a simplified version of my original patch. We now are back at generating the ihash seed in Thread::Thread(), with a constant if CDS dumps, and on ihash generation we check that we ever only call it with a single thread.
> 
> This version looks good. I am running our tiers 1-4 just to be sure.
> 

Cool. I like the new version more, its simpler. Thank you!

> Thanks

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18735#issuecomment-2089645540