RFR: 8330027: Identity hashes of archived objects must be based on a reproducible random seed [v5]

[Thomas Stuefe]

On Fri, 3 May 2024 05:37:35 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   JDK-8330027-cds-ihash-reproducability.patch
>
> src/hotspot/share/runtime/synchronizer.cpp line 952:
> 
>> 950:   if (t == nullptr) {
>> 951:     Atomic::cmpxchg(&cds_dump_java_thread, t, cur);
>> 952:     return true;
> 
> I think this is not thread safe, as I got few intermittent asserts.

Hmm, it should not really need to be thread safe, since it should only ever be called from a single thread. Do the asserts always happen in the one and only java thread?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18735#discussion_r1588868487