RFR: 8302744: Refactor Hotspot container detection code

Severin Gehwolf sgehwolf at openjdk.org
Tue May 7 10:14:52 UTC 2024


On Tue, 7 May 2024 09:52:24 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> > Thanks all for the reviews! All good suggestions, though I'm not sure I like the macro approach @jdksjolen suggested. It still comes at the cost of harder to read code. I'll do further exploration and will hopefully come back with a better approach.
> 
> Yeah, the X-macro approach may not be the best either. This is clearly a trade off between ease of reading one function, and the ease of making many extremely similar functions with few lines of code.

Yes. Ideally, I'd like to reduce the duplication some other way.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19060#issuecomment-2097943537


More information about the hotspot-runtime-dev mailing list