RFR: 8331858: [nmt] VM.native_memory statistics should work in summary mode [v2]

Johan Sjölen jsjolen at openjdk.org
Tue May 14 10:04:03 UTC 2024


On Mon, 13 May 2024 17:46:07 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> src/hotspot/share/nmt/memTracker.cpp line 160:
>> 
>>> 158:     out->cr();
>>> 159:   }
>>> 160:   out->print_cr("Preinit state:");
>> 
>> Is there any functional difference here or is it only changing indentation?
>
> Hi @jdksjolen, are you referring to the indentation printing the tracking level? I can definitely revert the indentation there.

Aha, I see, you added an `if` branch there! It was hard to see with the styling change on top. I think it's fine as is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19179#discussion_r1599746024


More information about the hotspot-runtime-dev mailing list