RFR: 8332287: When printing arguments in error logs, quote arguments with whitespaces [v2]

Thomas Stuefe stuefe at openjdk.org
Thu May 16 15:11:02 UTC 2024


On Thu, 16 May 2024 12:35:47 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cast to unsigned
>
> src/hotspot/share/runtime/arguments.cpp line 1100:
> 
>> 1098:       bool ws = false;
>> 1099:       for (const char* p = s; *p && !ws; p++) {
>> 1100:         ws = isspace(*p);
> 
> Based on a [recommendation](https://en.cppreference.com/w/cpp/string/byte/isspace#:~:text=character%2C%20zero%20otherwise.-,Notes,-Like%20all%20other) from CPPReference, the argument of `isspace` should be casted to `unsigned char`.

ok, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19248#discussion_r1603559645


More information about the hotspot-runtime-dev mailing list