RFR: 8330647: Two CDS tests fail with -UseCompressedOops and UseSerialGC/UseParallelGC

[David Holmes]

On Thu, 16 May 2024 21:37:15 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> The following two tests contain `@requires vm.cds.write.archived.java.heap` which implies `UseG1GC && UseCompressedClassPointers`
> 
> cds/appcds/cacheObject/ArchiveHeapTestClass.java
> cds/serviceability/ReplaceCriticalClassesForSubgraphs.java
> 
> The tests would fail if options conflicting with `vm.cds.write.archived.java.heap` are specified via the ` -Dtest.cds.runtime.options` property because the options would be added after the `@require` check.
> 
> A fix is to check if the ` -Dtest.cds.runtime.options` property contains non-null value and throws a `SkippedException`.

Can't the code that implements the `@requires` check also check for that property?

-------------

PR Review: https://git.openjdk.org/jdk/pull/19274#pullrequestreview-2062203116