RFR: 8302744: Refactor Hotspot container detection code

Jan Kratochvil jkratochvil at openjdk.org
Sun May 19 23:24:01 UTC 2024


On Tue, 7 May 2024 09:40:15 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 79:
>> 
>>> 77: PRAGMA_DIAG_PUSH
>>> 78: PRAGMA_FORMAT_NONLITERAL_IGNORED
>>> 79: template <typename T> int __cg_file_contents_impl(const char *absolute_path,
>> 
>> Can we please have the `template <typename T>` separate from the rest of the function type? What's the significance of the double underscore prefix in the naming?
>
>> What's the significance of the double underscore prefix in the naming
> 
> The idea is that it shouldn't be used directly, but `cg_file_contents_ctrl` be used instead. Maybe I can get rid of this ugliness in the next iteration.

https://stackoverflow.com/a/224420/2995591

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19060#discussion_r1606122057


More information about the hotspot-runtime-dev mailing list