RFR: 8332360: JVM hangs at exit when running on a uniprocessor [v2]
Coleen Phillimore
coleenp at openjdk.org
Mon May 20 13:04:04 UTC 2024
On Mon, 20 May 2024 12:54:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Restored the TryLock in the ReenterI (wait) case with a comment.
>>
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix comment
I agree that hoisting the first TryLock out of the loop would be correct, but I can't wrap my head around the non-mt case. If the TryLock after the park fails, is it possible for the one before the next park could succeed. IE as if spin count = 2? Anyway, I prefer restoring the code as it was since there is a TrySpin there and it gives the chance to explain why the TryLock is also required, and there are other things going on in this code that I don't want to interfere with.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19293#issuecomment-2120418242
More information about the hotspot-runtime-dev
mailing list