RFR: 8313562: hsperfdata should export module path and "launcher" metadata

Mon May 20 17:17:04 UTC 2024

On Fri, 17 May 2024 18:11:11 GMT, Larry Cable <duke at openjdk.org> wrote:

> hsperfdata should expose module metadata if available.

I also note that "jdk.debug property is a JAVA_PROPERTY, so not sure 
what to do here in the presence of this potential "precident"?

- Larry

On 5/19/24 6:27 PM, David Holmes wrote:
>
> ***@***.**** commented on this pull request.
>
> ------------------------------------------------------------------------
>
> In src/hotspot/share/runtime/statSampler.cpp 
> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*discussion_r1606153336__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKpGKpTb0Q$>:
>
> > +
> +  add_property_constant(JAVA_PROPERTY, "jdk.module.path", CHECK);
> +  add_property_constant(JAVA_PROPERTY, "jdk.module.upgrade.path", CHECK);
> +  add_property_constant(JAVA_PROPERTY, "jdk.module.main", CHECK);
>
> These are not "java" properties - do we need to add a "jdk" namespace?
>
> —
> Reply to this email directly, view it on GitHub 
> <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*pullrequestreview-2065206278__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoDdBf2XA$>, 
> or unsubscribe 
> <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67UX7E7U7AU4SIHC4NTZDFGR5AVCNFSM6AAAAABH4SJC22VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRVGIYDMMRXHA__;!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoAsCXxPg$>.
> You are receiving this because you were mentioned.Message ID: 
> ***@***.***>
>

--------------7k0FeE9fQIGLR7ZxNRvoacUT
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    I also note that "jdk.debug property is a JAVA_PROPERTY, so not sure
    what to do here in the presence of this potential "precident"?<br>
    <br>
    - Larry<br>
    <br>
    <div class="moz-cite-prefix">On 5/19/24 6:27 PM, David Holmes wrote:<br>
    </div>
    <blockquote type="cite" ***@***.***">

      ***@***.***</b> commented on this pull request.</p>
      <hr>
      <p>In <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*discussion_r1606153336__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKpGKpTb0Q$" moz-do-not-send="true">src/hotspot/share/runtime/statSampler.cpp</a>:</p>
      <pre style="color:#555">> +
+  add_property_constant(JAVA_PROPERTY, "jdk.module.path", CHECK);
+  add_property_constant(JAVA_PROPERTY, "jdk.module.upgrade.path", CHECK);
+  add_property_constant(JAVA_PROPERTY, "jdk.module.main", CHECK);
</pre>
      <p dir="auto">These are not "java" properties - do we need to add
        a "jdk" namespace?</p>
      <p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
        Reply to this email directly, <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/19287*pullrequestreview-2065206278__;Iw!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoDdBf2XA$" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ANTA67UX7E7U7AU4SIHC4NTZDFGR5AVCNFSM6AAAAABH4SJC22VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRVGIYDMMRXHA__;!!ACWV5N9M2RV99hQ!J2zDS-JPZ6lYQCvMtioTgnwy2xyeXv7suGsbXKrZ2nVivFlTC417bpvocgXEm8XKPz4g4ZmSVZ7LUZ9FMKoAsCXxPg$" moz-do-not-send="true">unsubscribe</a>.<br>
        You are receiving this because you were mentioned.<img src="https://github.com/notifications/beacon/ANTA67XWTXTQWDHXMA3FCILZDFGR5A5CNFSM6AAAAABH4SJC22WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT3DCGAM.gif" alt="" moz-do-not-send="true" width="1" height="1"><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
          ID: <span><openjdk/jdk/pull/19287/review/2065206278</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
      <script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "https://github.com/openjdk/jdk/pull/19287#pullrequestreview-2065206278",
"url": "https://github.com/openjdk/jdk/pull/19287#pullrequestreview-2065206278",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
    </blockquote>
    <br>
  </body>
</html>

--------------7k0FeE9fQIGLR7ZxNRvoacUT--

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19287#issuecomment-2120862356