RFR: 8313562: hsperfdata should export module path and "launcher" metadata

[Larry Cable]

On Mon, 20 May 2024 01:27:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> hsperfdata should expose module metadata if available.
>
> src/hotspot/share/runtime/statSampler.cpp line 266:
> 
>> 264:   add_property_constant(JAVA_PROPERTY, "jdk.module.path", CHECK);
>> 265:   add_property_constant(JAVA_PROPERTY, "jdk.module.upgrade.path", CHECK);
>> 266:   add_property_constant(JAVA_PROPERTY, "jdk.module.main", CHECK);
> 
> These are not "java" properties - do we need to add a "jdk" namespace?

correct @dholmes-ora however a couple of points to note:

- these properties *are* listed in the javadoc for System::getProperties also "jdk.debug" is a pre-existing property also present in the JAVA_PROPERTY NS ... which somewhat sets an awkward precedent...

happy to add a new JDK_PROPERTY NS but given the pre-existence of "jdk.debug" not clear to me that such would not introduce an arbitrary inconsistency

thoughts?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19287#discussion_r1607103455