RFR: 8302744: Refactor Hotspot container detection code [v2]

[Johan Sjölen]

On Tue, 21 May 2024 16:02:18 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Fix TestMemoryAwareness for cgroup v2
>>    
>>    It only reads the swap value, thus doesn't print:
>>    "Memory and Swap Limit is" but rather prints:
>>    "Swap Limit is". This is fine, since for cg v2
>>    the memory limit and the swap limits are in different
>>    files.
>>  - Fix whitespace
>>  - Handle cpu quota for cgroups v1 specially
>>  - Try a different approach.
>>    
>>    Hybrid MACRO usage and locked down reading primitives.
>>  - Add key-value read function
>>  - Add basic testing for read functions
>>  - Add generic julong/char* read functions
>>  - Merge branch 'master' into jdk-8302744-cleanup-getcontainer-info
>>  - 8302744: Refactor Hotspot container detection code
>
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 95:
> 
>> 93: 
>> 94: 
>> 95: enum TupleValue { FIRST, SECOND };
> 
> Suggestion/nit: Enum class + `First`, `Second`. Your choice to keep it as is, however.

I really want a more descriptive name and/or comment for this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19060#discussion_r1608588343